asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Accept filter_chain by reference and clone when needed

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-09-03 07:46:24 -03:00
parent 5afe2f6bc8
commit e34d0e315b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/item_service.rs
View File

@@ -197,7 +197,7 @@ impl ItemService {
&self, &self,
conn: &Connection, conn: &Connection,
id: i64, id: i64,
filter_chain: Option<filter_plugin::FilterChain>, filter_chain: Option<&filter_plugin::FilterChain>,
) -> Result<(Box<dyn Read + Send>, String, bool), CoreError> { ) -> Result<(Box<dyn Read + Send>, String, bool), CoreError> {
let item_with_meta = self.get_item(conn, id)?; let item_with_meta = self.get_item(conn, id)?;
let item_id = item_with_meta.item.id.ok_or_else(|| CoreError::InvalidInput("Item missing ID".to_string()))?; let item_id = item_with_meta.item.id.ok_or_else(|| CoreError::InvalidInput("Item missing ID".to_string()))?;
@@ -215,7 +215,7 @@ impl ItemService {
)?; )?;
// Wrap the reader with filtering // Wrap the reader with filtering
let filtered_reader = Box::new(FilteringReader::new(reader, filter_chain)); let filtered_reader = Box::new(FilteringReader::new(reader, filter_chain.cloned()));
let metadata = item_with_meta.meta_as_map(); let metadata = item_with_meta.meta_as_map();
let mime_type = metadata let mime_type = metadata