From e34d0e315b1442347e580df4914cc33913160a11 Mon Sep 17 00:00:00 2001
From: Andrew Phillips <andrew.phillips2@canada.ca>
Date: Wed, 3 Sep 2025 07:46:24 -0300
Subject: [PATCH] refactor: Accept `filter_chain` by reference and clone when
 needed

Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
---
 src/services/item_service.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/services/item_service.rs b/src/services/item_service.rs
index 2939d8b..b0b38eb 100644
--- a/src/services/item_service.rs
+++ b/src/services/item_service.rs
@@ -197,7 +197,7 @@ impl ItemService {
         &self,
         conn: &Connection,
         id: i64,
-        filter_chain: Option<filter_plugin::FilterChain>,
+        filter_chain: Option<&filter_plugin::FilterChain>,
     ) -> Result<(Box<dyn Read + Send>, String, bool), CoreError> {
         let item_with_meta = self.get_item(conn, id)?;
         let item_id = item_with_meta.item.id.ok_or_else(|| CoreError::InvalidInput("Item missing ID".to_string()))?;
@@ -215,7 +215,7 @@ impl ItemService {
         )?;
 
         // Wrap the reader with filtering
-        let filtered_reader = Box::new(FilteringReader::new(reader, filter_chain));
+        let filtered_reader = Box::new(FilteringReader::new(reader, filter_chain.cloned()));
 
         let metadata = item_with_meta.meta_as_map();
         let mime_type = metadata