Commit Graph

707 Commits

Author SHA1 Message Date
Andrew Phillips
cb408bafa1 fix: use database transactions for atomic operations in save and update modes
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-09 23:33:53 -03:00
Andrew Phillips
a3eb9e7056 fix: address critical memory safety, error handling, concurrency and security issues
This commit fixes several critical issues across the codebase:
1. Memory safety & resource leaks: Added proper cleanup for compression engine processes using RAII patterns
2. Error handling: Replaced unsafe unwrap() calls with proper error propagation using ok_or_else()?
3. Concurrency issues: Improved diff mode thread safety with proper error handling and RAII guards
4. Security concerns: Added validation for item IDs to prevent path traversal vulnerabilities
5. Database design: Wrapped database operations in transactions for atomicity in save/update modes

Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-09 23:33:06 -03:00
Andrew Phillips
ebada59764 fix: add missing import for FORMAT_NO_BORDER_LINE_SEPARATOR constant
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 15:40:39 -03:00
Andrew Phillips
983c9f20fa fix: remove unused imports and fix test stdin handling
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 15:39:54 -03:00
Andrew Phillips
ada0805671 fix: resolve Alignment import error in list mode and remove unused imports
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 15:38:22 -03:00
Andrew Phillips
3008f3fec0 fix: resolve compilation errors and warnings in keep crate
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 15:37:43 -03:00
Andrew Phillips
52618586d1 chore: remove unused dependencies and dead code
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 14:53:07 -03:00
Andrew Phillips
291b6d9587 feat: implement batch queries for improved list performance
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 14:26:26 -03:00
Andrew Phillips
cae1cfcaf2 fix: resolve borrowing issue in meta plugin support check
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 14:11:01 -03:00
Andrew Phillips
13a2747a8d fix: warn and remove unsupported meta plugins in save mode
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 14:04:19 -03:00
Andrew Phillips
a8717f4b94 feat: warn when meta plugins are enabled but not supported
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 14:01:27 -03:00
Andrew Phillips
cd092ab3ea fix: remove unused import in status module
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:59:07 -03:00
Andrew Phillips
f32f898784 refactor: Remove duplicated program info definitions in status mode
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:56:41 -03:00
Andrew Phillips
9615e684f0 refactor: use MetaPlugin.is_supported() to determine plugin status display
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:53:11 -03:00
Andrew Phillips
93046a220e refactor: remove META_PLUGIN_PROGRAMS and use get_meta_plugin() instead
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:48:25 -03:00
Andrew Phillips
ca8629a3ac refactor: reorganize meta plugins table to show Meta Name first and remove Type column
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:02:33 -03:00
Andrew Phillips
471fc1b98d fix: apply BRIGHT_BLACK style only to "<INTERNAL>" in status mode binary column
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 13:00:45 -03:00
Andrew Phillips
1e00c30543 fix: apply BRIGHT_BLACK style to <INTERNAL> in meta plugin table
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:59:13 -03:00
Andrew Phillips
ca6a1a455c fix: ignore KEEP_META_PLUGINS when searching for metadata environment variables
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:17:49 -03:00
Andrew Phillips
6452eee203 fix: clone meta_name before moving it to store_item_meta_value
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:12:44 -03:00
Andrew Phillips
3de832d886 feat: add hostname and full_hostname meta plugins with error handling
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:11:46 -03:00
Andrew Phillips
ed22df4b98 fix: add missing IntoEnumIterator import for MetaPluginType::iter() usage
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:01:16 -03:00
Andrew Phillips
14c2c347cb fix: lookup meta plugins by meta name instead of type name
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 12:00:29 -03:00
Andrew Phillips
3bbce80d2d fix: support comma-separated meta plugin types and reorganize read time/rate plugins
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:57:22 -03:00
Andrew Phillips
00ee90a6d9 feat: add enabled column to meta plugins status table
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:49:48 -03:00
Andrew Phillips
05af560399 refactor: remove default column from meta plugin status table and simplify default logic
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:46:02 -03:00
Andrew Phillips
632184221b fix: correctly display meta plugin implementation status in status mode
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:42:37 -03:00
Andrew Phillips
ee6869a94c fix: make meta_plugin mutable to call meta_name() method
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:19:12 -03:00
Andrew Phillips
0c29102369 fix: correctly detect internal meta plugins as supported in status display
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:17:53 -03:00
Andrew Phillips
d0ac4cf637 fix: reorder variable declarations to fix scope issue with meta_plugin_types
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-29 11:05:25 -03:00
Andrew Phillips
e51a902660 refactor: integrate digest functionality into meta plugins and remove digest_engine module
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-28 17:31:23 -03:00
Andrew Phillips
4c8c6569a9 feat: add function to store item meta values 2025-07-28 17:31:12 -03:00
Andrew Phillips
d666cfce00 refactor: reimplement digest engines as meta plugins
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-28 17:12:13 -03:00
Andrew Phillips
0bf898c0e7 fix: correctly track and log item size during IO loop 2025-07-28 17:12:10 -03:00
Andrew Phillips
00572135ec fix: use MetaPluginProgram::new constructor for private fields
Co-authored-by: aider (openai/andrew.openrouter.qwen.qwen3-coder) <aider@aider.chat>
2025-07-28 16:58:18 -03:00
Andrew Phillips (aider)
888f24640e chore: remove unused import and fix mutable borrow issue 2025-05-22 16:44:07 -03:00
Andrew Phillips (aider)
7e9b22ceb6 fix: add missing imports in save.rs 2025-05-22 16:41:39 -03:00
Andrew Phillips (aider)
cbd7ec8fe0 fix: use iter_mut() for mutable meta_plugins 2025-05-22 16:39:27 -03:00
Andrew Phillips
6f5c3c3dd4 feat: add meta plugin support to save mode 2025-05-22 16:39:23 -03:00
Andrew Phillips (aider)
7a8814e926 feat: implement meta plugin initialization in save mode 2025-05-22 16:27:11 -03:00
Andrew Phillips
6935ea2dea refactor: extract digest and compression engine initialization 2025-05-22 16:27:09 -03:00
Andrew Phillips
fee358c406 refactor: update debug logging for digest and compression types 2025-05-22 16:20:02 -03:00
Andrew Phillips (aider)
cff08905a8 fix: replace unwrap_or_else with unwrap_or_default for Vec<String> 2025-05-22 15:56:53 -03:00
Andrew Phillips (aider)
335c0e8a6f fix: replace unwrap_or_default with unwrap_or_else for Vec<String> 2025-05-22 15:52:28 -03:00
Andrew Phillips (aider)
af84c332ea fix: correct import statements and method usage 2025-05-22 15:49:34 -03:00
Andrew Phillips
f0ef529da5 feat: add meta plugin types support 2025-05-22 15:49:32 -03:00
Andrew Phillips (aider)
4ef75a6917 chore: implement meta plugin type parsing in cmd_args_meta_plugin_types 2025-05-22 15:44:58 -03:00
Andrew Phillips
d4d17b93e1 feat: add meta plugin type argument parsing 2025-05-22 15:44:56 -03:00
Andrew Phillips (aider)
970d69af70 chore: remove unused imports 2025-05-22 14:02:24 -03:00
Andrew Phillips (aider)
a68d75351f refactor: remove magic function and related code 2025-05-22 13:57:00 -03:00