Commit Graph

32 Commits

Author SHA1 Message Date
Andrew Phillips
99949cf1ee fix: resolve compilation errors in API paths and file descriptor handling
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-13 11:22:46 -03:00
Andrew Phillips
6c9074f1be fix: reorder OpenAPI paths and fix file descriptor handling in diff mode
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-13 11:21:14 -03:00
Andrew Phillips
e66af572d3 fix: resolve compilation errors in API paths and file descriptor handling
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-13 11:20:05 -03:00
Andrew Phillips
baf92a8902 fix: resolve compilation errors in API routes and diff pipe setup
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-13 11:19:05 -03:00
Andrew Phillips
d5ee57863a fix: resolve compilation errors in API paths, file descriptors, and router merging
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-13 11:08:37 -03:00
Andrew Phillips
469e3640b8 fix: resolve compilation errors by fixing mutable references and removing unused imports
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-10 00:23:58 -03:00
Andrew Phillips
e1c0c81445 fix: resolve compilation errors by adding missing imports and fixing Result types
- Import `anyhow`, `clap::Command`, `log::debug`, and I/O traits
- Fix all `Result` return types to include error type `anyhow::Error`
- Replace `anyhow::anyhow!` with `anyhow!` macro calls
- Fix transaction handling in `mode_save`
- Add missing trait imports for I/O operations and string parsing

Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-10 00:19:00 -03:00
Andrew Phillips
58f047ba6d fix: improve error messages and refactor large functions in save/diff modes
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-10 00:00:33 -03:00
Andrew Phillips
a3eb9e7056 fix: address critical memory safety, error handling, concurrency and security issues
This commit fixes several critical issues across the codebase:
1. Memory safety & resource leaks: Added proper cleanup for compression engine processes using RAII patterns
2. Error handling: Replaced unsafe unwrap() calls with proper error propagation using ok_or_else()?
3. Concurrency issues: Improved diff mode thread safety with proper error handling and RAII guards
4. Security concerns: Added validation for item IDs to prevent path traversal vulnerabilities
5. Database design: Wrapped database operations in transactions for atomicity in save/update modes

Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
2025-08-09 23:33:06 -03:00
Andrew Phillips
dd8f828ed3 refactor: update function parameters to use references where appropriate 2025-05-14 22:09:23 -03:00
Andrew Phillips
bbdfe19836 feat: add compression and digest support with database schema updates 2025-05-14 09:45:51 -03:00
Andrew Phillips
0189f3c273 refactor: remove module prefixes from compression and digest engine functions 2025-05-13 15:00:30 -03:00
Andrew Phillips (aider)
8f93657fa1 refactor: consolidate imports for get_*_engine functions 2025-05-13 09:00:45 -03:00
Andrew Phillips (aider)
41ac4dafaf refactor: rename get_engine to get_compression_engine in diff mode 2025-05-13 08:54:04 -03:00
Andrew Phillips (aider)
e15cf371e0 refactor: Update imports to use specific get_engine functions 2025-05-13 08:51:21 -03:00
Andrew Phillips (aider)
71a35a77a0 fix: correct compression module imports 2025-05-12 17:16:52 -03:00
Andrew Phillips (aider)
66e61a4196 refactor: move compression types to compression_engine module 2025-05-12 17:12:17 -03:00
Andrew Phillips
d9072d22d5 refactor: improve test structure and reliability 2025-05-12 13:07:33 -03:00
Andrew Phillips (aider)
f9969a7537 fix: use libc::c_int for file descriptor instead of nix::Fd 2025-05-12 11:16:46 -03:00
Andrew Phillips (aider)
723ec2a6e8 fix: convert Fd to raw descriptor using .0 access
This addresses the E0412 error by correctly extracting the raw file descriptor from the nix::unistd::Fd newtype wrapper.
2025-05-12 11:15:32 -03:00
Andrew Phillips (aider)
f9dd390a12 fix: convert nix Fd to raw fd using into_raw() 2025-05-12 11:14:44 -03:00
Andrew Phillips (aider)
d31ab6e793 refactor: centralize thread spawning for item writing 2025-05-12 11:13:06 -03:00
Andrew Phillips (aider)
f3f3c6d628 refactor: extract common function for writing item data to pipe with fd argument 2025-05-12 11:10:00 -03:00
Andrew Phillips (aider)
825ff7a451 fix: remove unused import and method 2025-05-12 10:51:00 -03:00
Andrew Phillips
bb7ed06e9c refactor: update debug logs to use log::debug macro 2025-05-12 10:50:54 -03:00
Andrew Phillips (aider)
e6cc479b32 refactor: Replace debug! with log::debug! in diff module logging statements 2025-05-12 10:45:22 -03:00
Andrew Phillips (aider)
47e0a1d51c fix: add log::debug macro and remove unused imports 2025-05-12 10:40:49 -03:00
Andrew Phillips (aider)
74e4db0f65 fix: resolve duplicate imports and add log::debug prefixes 2025-05-12 10:23:52 -03:00
Andrew Phillips
9418bf58ea refactor: Remove mode_diff implementation and dependencies 2025-05-12 10:23:28 -03:00
Andrew Phillips (aider)
8594a292f9 fix: add missing diff module and mode_diff implementation 2025-05-12 10:20:24 -03:00
Andrew Phillips (aider)
4741314493 refactor: Move mode_diff to src/modes/diff.rs and update imports 2025-05-12 10:00:05 -03:00
Andrew Phillips (aider)
d669beca5a (no commit message provided) 2025-05-12 09:01:45 -03:00