From ffe71440d9cf2b998058c9f751a366376d2db89a Mon Sep 17 00:00:00 2001 From: Andrew Phillips Date: Sat, 14 Mar 2026 18:26:58 -0300 Subject: [PATCH] fix: use explicit snake_case serialization for CompressionType MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per project convention, enum string representations should use snake_case. Use explicit strum serialize attributes instead of serialize_all to avoid incorrect splitting of acronyms like GZip → g_zip and ZStd → z_std. --- src/compression_engine/mod.rs | 6 ++++++ src/tests/compression_types/conversion_tests.rs | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/compression_engine/mod.rs b/src/compression_engine/mod.rs index e4b7047..46fd15e 100644 --- a/src/compression_engine/mod.rs +++ b/src/compression_engine/mod.rs @@ -34,11 +34,17 @@ use crate::compression_engine::program::CompressionEngineProgram; #[derive(Debug, Eq, PartialEq, Clone, EnumIter, Display, EnumString, enum_map::Enum)] #[strum(ascii_case_insensitive)] pub enum CompressionType { + #[strum(serialize = "lz4")] LZ4, + #[strum(serialize = "gzip")] GZip, + #[strum(serialize = "bzip2")] BZip2, + #[strum(serialize = "xz")] XZ, + #[strum(serialize = "zstd")] ZStd, + #[strum(serialize = "none")] None, } diff --git a/src/tests/compression_types/conversion_tests.rs b/src/tests/compression_types/conversion_tests.rs index 5b6bd81..89d5f78 100644 --- a/src/tests/compression_types/conversion_tests.rs +++ b/src/tests/compression_types/conversion_tests.rs @@ -5,9 +5,9 @@ mod tests { #[test] fn test_compression_type_display() { - assert_eq!(format!("{}", CompressionType::LZ4), "LZ4"); - assert_eq!(format!("{}", CompressionType::GZip), "GZip"); - assert_eq!(format!("{}", CompressionType::None), "None"); + assert_eq!(format!("{}", CompressionType::LZ4), "lz4"); + assert_eq!(format!("{}", CompressionType::GZip), "gzip"); + assert_eq!(format!("{}", CompressionType::None), "none"); } #[test]