asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: remove new_simple methods and replace with new(None, None)

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-27 13:59:37 -03:00
parent de6cdf6bfc
commit fdcccc844e
14 changed files with 18 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/meta_plugin/mod.rs
View File

@@ -256,26 +256,25 @@ pub trait MetaPlugin where Self: 'static {
}
pub fn get_meta_plugin(meta_plugin_type: MetaPluginType) -> Box<dyn MetaPlugin> {
// For now, use new_simple() which passes None for options and outputs
// The calling code should be updated to use a different function that accepts options and outputs
// Use new(None, None) which passes None for options and outputs
match meta_plugin_type {
MetaPluginType::FileMagic => Box::new(MetaPluginProgram::new_simple("file", vec!["-bE", "-"], "file_magic".to_string(), true)),
MetaPluginType::FileMime => Box::new(MetaPluginProgram::new_simple("file", vec!["-b", "--mime-type", "-"], "file_mime".to_string(), true)),
MetaPluginType::FileEncoding => Box::new(MetaPluginProgram::new_simple("file", vec!["-b", "--mime-encoding", "-"], "file_encoding".to_string(), true)),
MetaPluginType::MagicFile => Box::new(MagicFileMetaPlugin::new_simple()),
MetaPluginType::LineCount => Box::new(MetaPluginProgram::new_simple("wc", vec!["-l"], "line_count".to_string(), true)),
MetaPluginType::WordCount => Box::new(MetaPluginProgram::new_simple("wc", vec!["-w"], "word_count".to_string(), true)),
MetaPluginType::Cwd => Box::new(CwdMetaPlugin::new_simple()),
MetaPluginType::Binary => Box::new(BinaryMetaPlugin::new_simple()),
MetaPluginType::Text => Box::new(TextMetaPlugin::new_simple()),
MetaPluginType::User => Box::new(UserMetaPlugin::new_simple()),
MetaPluginType::Shell => Box::new(ShellMetaPlugin::new_simple()),
MetaPluginType::ShellPid => Box::new(ShellPidMetaPlugin::new_simple()),
MetaPluginType::KeepPid => Box::new(KeepPidMetaPlugin::new_simple()),
MetaPluginType::Digest => Box::new(DigestMetaPlugin::new_simple()),
MetaPluginType::ReadTime => Box::new(ReadTimeMetaPlugin::new_simple()),
MetaPluginType::ReadRate => Box::new(ReadRateMetaPlugin::new_simple()),
MetaPluginType::Hostname => Box::new(HostnameMetaPlugin::new_simple()),
MetaPluginType::FileMagic => Box::new(MetaPluginProgram::new("file", vec!["-bE", "-"], "file_magic".to_string(), true, None, None)),
MetaPluginType::FileMime => Box::new(MetaPluginProgram::new("file", vec!["-b", "--mime-type", "-"], "file_mime".to_string(), true, None, None)),
MetaPluginType::FileEncoding => Box::new(MetaPluginProgram::new("file", vec!["-b", "--mime-encoding", "-"], "file_encoding".to_string(), true, None, None)),
MetaPluginType::MagicFile => Box::new(MagicFileMetaPlugin::new(None, None)),
MetaPluginType::LineCount => Box::new(MetaPluginProgram::new("wc", vec!["-l"], "line_count".to_string(), true, None, None)),
MetaPluginType::WordCount => Box::new(MetaPluginProgram::new("wc", vec!["-w"], "word_count".to_string(), true, None, None)),
MetaPluginType::Cwd => Box::new(CwdMetaPlugin::new(None, None)),
MetaPluginType::Binary => Box::new(BinaryMetaPlugin::new(None, None)),
MetaPluginType::Text => Box::new(TextMetaPlugin::new(None, None)),
MetaPluginType::User => Box::new(UserMetaPlugin::new(None, None)),
MetaPluginType::Shell => Box::new(ShellMetaPlugin::new(None, None)),
MetaPluginType::ShellPid => Box::new(ShellPidMetaPlugin::new(None, None)),
MetaPluginType::KeepPid => Box::new(KeepPidMetaPlugin::new(None, None)),
MetaPluginType::Digest => Box::new(DigestMetaPlugin::new(None, None)),
MetaPluginType::ReadTime => Box::new(ReadTimeMetaPlugin::new(None, None)),
MetaPluginType::ReadRate => Box::new(ReadRateMetaPlugin::new(None, None)),
MetaPluginType::Hostname => Box::new(HostnameMetaPlugin::new(None, None)),
}
}