feat: update default is_internal() to return true and clean up overrides
Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
@@ -120,7 +120,7 @@ pub trait MetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn is_internal(&self) -> bool {
|
fn is_internal(&self) -> bool {
|
||||||
false
|
true
|
||||||
}
|
}
|
||||||
|
|
||||||
// Update the meta plugin with new data
|
// Update the meta plugin with new data
|
||||||
|
|||||||
@@ -65,9 +65,6 @@ impl BinaryMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for BinaryMetaPlugin {
|
impl MetaPlugin for BinaryMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn update(&mut self, data: &[u8]) -> MetaPluginResponse {
|
fn update(&mut self, data: &[u8]) -> MetaPluginResponse {
|
||||||
// Calculate how much data we can still accept
|
// Calculate how much data we can still accept
|
||||||
|
|||||||
@@ -54,9 +54,6 @@ impl DigestSha256MetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for DigestSha256MetaPlugin {
|
impl MetaPlugin for DigestSha256MetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
|
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
|
||||||
self.item_id = Some(item_id);
|
self.item_id = Some(item_id);
|
||||||
@@ -165,9 +162,6 @@ impl ReadTimeMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for ReadTimeMetaPlugin {
|
impl MetaPlugin for ReadTimeMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self) -> Result<MetaPluginResponse> {
|
fn finalize(&mut self) -> Result<MetaPluginResponse> {
|
||||||
let mut metadata = Vec::new();
|
let mut metadata = Vec::new();
|
||||||
@@ -274,9 +268,6 @@ impl ReadRateMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for ReadRateMetaPlugin {
|
impl MetaPlugin for ReadRateMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self) -> Result<MetaPluginResponse> {
|
fn finalize(&mut self) -> Result<MetaPluginResponse> {
|
||||||
let mut metadata = Vec::new();
|
let mut metadata = Vec::new();
|
||||||
|
|||||||
@@ -118,9 +118,6 @@ impl MagicFileMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for MagicFileMetaPlugin {
|
impl MetaPlugin for MagicFileMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
|
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
|
||||||
self.item_id = Some(item_id);
|
self.item_id = Some(item_id);
|
||||||
|
|||||||
@@ -53,9 +53,6 @@ impl CwdMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for CwdMetaPlugin {
|
impl MetaPlugin for CwdMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self) -> MetaPluginResponse {
|
fn finalize(&mut self) -> MetaPluginResponse {
|
||||||
MetaPluginResponse {
|
MetaPluginResponse {
|
||||||
@@ -158,9 +155,6 @@ impl UidMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for UidMetaPlugin {
|
impl MetaPlugin for UidMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -261,9 +255,6 @@ impl UserMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for UserMetaPlugin {
|
impl MetaPlugin for UserMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -360,9 +351,6 @@ impl GidMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for GidMetaPlugin {
|
impl MetaPlugin for GidMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -456,9 +444,6 @@ impl GroupMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for GroupMetaPlugin {
|
impl MetaPlugin for GroupMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -555,9 +540,6 @@ impl ShellMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for ShellMetaPlugin {
|
impl MetaPlugin for ShellMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -654,9 +636,6 @@ impl ShellPidMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for ShellPidMetaPlugin {
|
impl MetaPlugin for ShellPidMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -753,9 +732,6 @@ impl KeepPidMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for KeepPidMetaPlugin {
|
impl MetaPlugin for KeepPidMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -849,9 +825,6 @@ impl HostnameMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for HostnameMetaPlugin {
|
impl MetaPlugin for HostnameMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
@@ -948,9 +921,6 @@ impl FullHostnameMetaPlugin {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl MetaPlugin for FullHostnameMetaPlugin {
|
impl MetaPlugin for FullHostnameMetaPlugin {
|
||||||
fn is_internal(&self) -> bool {
|
|
||||||
true
|
|
||||||
}
|
|
||||||
|
|
||||||
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
|
||||||
// Since we save during initialize(), return Ok to avoid duplicate saves
|
// Since we save during initialize(), return Ok to avoid duplicate saves
|
||||||
|
|||||||
Reference in New Issue
Block a user