feat: update default is_internal() to return true and clean up overrides

Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-26 17:27:04 -03:00
parent a0fcd3f3e7
commit f44866a2cc
5 changed files with 1 additions and 46 deletions

View File

@@ -120,7 +120,7 @@ pub trait MetaPlugin {
}
fn is_internal(&self) -> bool {
false
true
}
// Update the meta plugin with new data

View File

@@ -65,9 +65,6 @@ impl BinaryMetaPlugin {
}
impl MetaPlugin for BinaryMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn update(&mut self, data: &[u8]) -> MetaPluginResponse {
// Calculate how much data we can still accept

View File

@@ -54,9 +54,6 @@ impl DigestSha256MetaPlugin {
}
impl MetaPlugin for DigestSha256MetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
self.item_id = Some(item_id);
@@ -165,9 +162,6 @@ impl ReadTimeMetaPlugin {
}
impl MetaPlugin for ReadTimeMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self) -> Result<MetaPluginResponse> {
let mut metadata = Vec::new();
@@ -274,9 +268,6 @@ impl ReadRateMetaPlugin {
}
impl MetaPlugin for ReadRateMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self) -> Result<MetaPluginResponse> {
let mut metadata = Vec::new();

View File

@@ -118,9 +118,6 @@ impl MagicFileMetaPlugin {
}
impl MetaPlugin for MagicFileMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn initialize(&mut self, item_id: i64) -> Result<MetaPluginResponse> {
self.item_id = Some(item_id);

View File

@@ -53,9 +53,6 @@ impl CwdMetaPlugin {
}
impl MetaPlugin for CwdMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self) -> MetaPluginResponse {
MetaPluginResponse {
@@ -158,9 +155,6 @@ impl UidMetaPlugin {
}
impl MetaPlugin for UidMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -261,9 +255,6 @@ impl UserMetaPlugin {
}
impl MetaPlugin for UserMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -360,9 +351,6 @@ impl GidMetaPlugin {
}
impl MetaPlugin for GidMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -456,9 +444,6 @@ impl GroupMetaPlugin {
}
impl MetaPlugin for GroupMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -555,9 +540,6 @@ impl ShellMetaPlugin {
}
impl MetaPlugin for ShellMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -654,9 +636,6 @@ impl ShellPidMetaPlugin {
}
impl MetaPlugin for ShellPidMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -753,9 +732,6 @@ impl KeepPidMetaPlugin {
}
impl MetaPlugin for KeepPidMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -849,9 +825,6 @@ impl HostnameMetaPlugin {
}
impl MetaPlugin for HostnameMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves
@@ -948,9 +921,6 @@ impl FullHostnameMetaPlugin {
}
impl MetaPlugin for FullHostnameMetaPlugin {
fn is_internal(&self) -> bool {
true
}
fn finalize(&mut self, _conn: &Connection) -> Result<()> {
// Since we save during initialize(), return Ok to avoid duplicate saves