asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Remove transaction from save to allow partial saves on failure

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-10 00:34:55 -03:00
parent a5bc9373a9
commit e390139425
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/modes/save.rs
View File

@@ -244,9 +244,8 @@ pub fn mode_save(
let mut item = create_and_log_item(conn, args, tags, &compression_type)?; let mut item = create_and_log_item(conn, args, tags, &compression_type)?;
setup_item_metadata(conn, args, &item, tags)?; // Pass mutable reference setup_item_metadata(conn, args, &item, tags)?; // Pass mutable reference
// Use a transaction for database operations to ensure atomicity // Save as much as possible in case something breaks - don't use transactions
let tx = conn.transaction()?; // This allows partial saves to succeed even if some metadata operations fail
let item_meta = collect_item_meta(args); let item_meta = collect_item_meta(args);
let item_id = item.id.ok_or_else(|| anyhow!("Item missing ID"))?; let item_id = item.id.ok_or_else(|| anyhow!("Item missing ID"))?;
@@ -256,7 +255,7 @@ pub fn mode_save(
name: kv.0.to_string(), name: kv.0.to_string(),
value: kv.1.to_string(), value: kv.1.to_string(),
}; };
crate::db::store_meta(&tx, meta)?; crate::db::store_meta(conn, meta)?;
} }
let (_item_out, processed_item) = process_input_stream( let (_item_out, processed_item) = process_input_stream(
@@ -269,11 +268,8 @@ pub fn mode_save(
item.size = processed_item.size; item.size = processed_item.size;
item.compression = compression_type.to_string(); item.compression = compression_type.to_string();
finalize_meta_plugins(&tx, &mut meta_plugins, &item)?; finalize_meta_plugins(conn, &mut meta_plugins, &item)?;
crate::db::update_item(&tx, item.clone())?; crate::db::update_item(conn, item.clone())?;
// Commit the transaction
tx.commit()?;
Ok(()) Ok(())
} }