asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove incorrect downcast_ref error handling

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-25 18:22:40 -03:00
parent 321e00171e
commit cd4838a474
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/modes/server/api/item.rs
View File

@@ -195,13 +195,6 @@ pub async fn handle_get_item_latest_content(
} }
Err(CoreError::ItemNotFoundGeneric) => Err(StatusCode::NOT_FOUND), Err(CoreError::ItemNotFoundGeneric) => Err(StatusCode::NOT_FOUND),
Err(e) => { Err(e) => {
// Check if the error is ItemNotFoundGeneric to return 404
if let Some(core_err) = e.downcast_ref::<CoreError>() {
match core_err {
CoreError::ItemNotFoundGeneric => return Err(StatusCode::NOT_FOUND),
_ => {}
}
}
warn!("Failed to find latest item for content: {}", e); warn!("Failed to find latest item for content: {}", e);
Err(StatusCode::INTERNAL_SERVER_ERROR) Err(StatusCode::INTERNAL_SERVER_ERROR)
} }
@@ -257,13 +250,6 @@ pub async fn handle_get_item_content(
Ok(response) Ok(response)
} }
Err(e) => { Err(e) => {
// Check if the error is ItemNotFound to return 404
if let Some(core_err) = e.downcast_ref::<CoreError>() {
match core_err {
CoreError::ItemNotFound(_) => return Err(StatusCode::NOT_FOUND),
_ => {}
}
}
warn!("Failed to get raw content for item {}: {}", item_id, e); warn!("Failed to get raw content for item {}: {}", item_id, e);
Err(StatusCode::INTERNAL_SERVER_ERROR) Err(StatusCode::INTERNAL_SERVER_ERROR)
} }