asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: remove redundant configure_options and default_options methods

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-27 10:43:30 -03:00
parent 5d518711d5
commit b7bf9b20de
14 changed files with 0 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/meta_plugin/mod.rs
View File

@@ -253,12 +253,6 @@ pub trait MetaPlugin where Self: 'static {
std::collections::HashMap::new()
}
// Configure plugin with options (excluding outputs)
fn configure_options(&mut self, _options: &std::collections::HashMap<String, serde_yaml::Value>) -> anyhow::Result<()> {
// Default implementation does nothing - plugins can override this
Ok(())
}
// Configure plugin outputs mapping
fn configure_outputs(&mut self, outputs: &std::collections::HashMap<String, serde_yaml::Value>) -> anyhow::Result<()> {
for (key, value) in outputs {
@@ -267,13 +261,6 @@ pub trait MetaPlugin where Self: 'static {
Ok(())
}
// Configure both options and outputs
fn configure(&mut self, options: &std::collections::HashMap<String, serde_yaml::Value>, outputs: &std::collections::HashMap<String, serde_yaml::Value>) -> anyhow::Result<()> {
self.configure_options(options)?;
self.configure_outputs(outputs)?;
Ok(())
}
// Method to downcast to concrete type (for checking finalization state)
fn as_any_mut(&mut self) -> &mut dyn std::any::Any where Self: Sized {
self