From a1a66c1920431af894628b2bc496941789802ef9 Mon Sep 17 00:00:00 2001 From: Andrew Phillips Date: Tue, 19 Aug 2025 13:33:10 -0300 Subject: [PATCH] fix: remove unused imports and fix settings default error Co-authored-by: aider (openai/andrew/openrouter/qwen/qwen3-coder) --- src/common/status.rs | 12 +++--------- src/meta_plugin.rs | 2 +- src/meta_plugin/binary.rs | 2 +- src/meta_plugin/digest.rs | 2 +- src/meta_plugin/magic.rs | 2 +- src/meta_plugin/system.rs | 2 +- 6 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/common/status.rs b/src/common/status.rs index e507ae5..a494dad 100644 --- a/src/common/status.rs +++ b/src/common/status.rs @@ -112,15 +112,9 @@ pub fn generate_status_info( // Plugin initialized successfully } - // Configure plugin with settings if available - // Create a dummy settings object to get plugin configs - let dummy_settings = config::Settings::default(); - if let Some(meta_plugin_configs) = &dummy_settings.meta_plugins { - if let Some(config) = meta_plugin_configs.iter().find(|c| c.name == meta_plugin.meta_name()) { - // Configure the plugin with options and outputs from config - let _ = meta_plugin.configure(&config.options, &config.outputs.iter().map(|(k, v)| (k.clone(), serde_yaml::Value::String(v.clone()))).collect()); - } - } + // Note: In status mode we don't have access to actual settings, + // so we can't configure plugins with their settings here. + // Plugin configuration happens during save operations. let (binary_display, args_display) = if !is_supported { ("".to_string(), "".to_string()) diff --git a/src/meta_plugin.rs b/src/meta_plugin.rs index e147279..4bfb85f 100644 --- a/src/meta_plugin.rs +++ b/src/meta_plugin.rs @@ -116,7 +116,7 @@ pub trait MetaPlugin { } // Configure plugin with options (excluding outputs) - fn configure_options(&mut self, options: &std::collections::HashMap) -> Result<()> { + fn configure_options(&mut self, _options: &std::collections::HashMap) -> Result<()> { // Default implementation does nothing - plugins can override this Ok(()) } diff --git a/src/meta_plugin/binary.rs b/src/meta_plugin/binary.rs index 65127ba..75cacc7 100644 --- a/src/meta_plugin/binary.rs +++ b/src/meta_plugin/binary.rs @@ -2,7 +2,7 @@ use anyhow::Result; use rusqlite::Connection; use crate::common::is_binary::is_binary; -use crate::meta_plugin::{MetaPlugin, output_metadata}; +use crate::meta_plugin::MetaPlugin; #[derive(Debug, Clone, Default)] pub struct BinaryMetaPlugin { diff --git a/src/meta_plugin/digest.rs b/src/meta_plugin/digest.rs index 162e370..bea1879 100644 --- a/src/meta_plugin/digest.rs +++ b/src/meta_plugin/digest.rs @@ -3,7 +3,7 @@ use sha2::{Digest, Sha256}; use std::time::Instant; use rusqlite::Connection; -use crate::meta_plugin::{MetaPlugin, output_metadata}; +use crate::meta_plugin::MetaPlugin; #[derive(Debug, Clone, Default)] pub struct DigestSha256MetaPlugin { diff --git a/src/meta_plugin/magic.rs b/src/meta_plugin/magic.rs index 12b635e..fcd929c 100644 --- a/src/meta_plugin/magic.rs +++ b/src/meta_plugin/magic.rs @@ -3,7 +3,7 @@ use magic::{Cookie, CookieFlags}; use rusqlite::Connection; use std::io; -use crate::meta_plugin::{MetaPlugin, output_metadata}; +use crate::meta_plugin::MetaPlugin; #[derive(Debug)] pub struct MagicFileMetaPlugin { diff --git a/src/meta_plugin/system.rs b/src/meta_plugin/system.rs index 0d4fbfe..32d2423 100644 --- a/src/meta_plugin/system.rs +++ b/src/meta_plugin/system.rs @@ -7,7 +7,7 @@ use std::process; use uzers::{get_current_uid, get_current_gid, get_current_username, get_current_groupname}; use rusqlite::Connection; -use crate::meta_plugin::{MetaPlugin, output_metadata}; +use crate::meta_plugin::MetaPlugin; #[derive(Debug, Clone, Default)] pub struct CwdMetaPlugin {