asp/keep
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: handle hostname false option properly

Browse Source 
Co-authored-by: aider (openai/andrew/openrouter/deepseek/deepseek-chat-v3.1) <aider@aider.chat>
This commit is contained in:
Andrew Phillips
2025-08-27 18:05:16 -03:00
parent 15e7c2b6e5
commit 75222eeb7f
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/meta_plugin/hostname.rs
View File

@@ -23,6 +23,18 @@ impl HostnameMetaPlugin {
// Override with provided options
if let Some(opts) = options {
for (key, value) in opts {
// Handle "false" string values by converting them to Bool(false)
if key == "hostname" || key == "hostname_full" || key == "hostname_short" {
if let serde_yaml::Value::String(s) = &value {
if s == "false" {
final_options.insert(key, serde_yaml::Value::Bool(false));
continue;
} else if s == "true" {
final_options.insert(key, serde_yaml::Value::Bool(true));
continue;
}
}
}
final_options.insert(key, value);
}
}
@@ -195,6 +207,9 @@ impl MetaPlugin for HostnameMetaPlugin {
_ => true,
};
// Ensure that if hostname is explicitly set to false, it's disabled
// This handles cases where it might be set to "false" string which we converted above
let hostname_full_enabled = self.options.get("hostname_full")
.and_then(|v| v.as_bool())
.unwrap_or(true);