From 670d078eae548fe6b2b028f1540bd69846b90d25 Mon Sep 17 00:00:00 2001 From: Andrew Phillips Date: Tue, 19 Aug 2025 14:20:45 -0300 Subject: [PATCH] fix: initialize final_options in meta plugin constructors Co-authored-by: aider (openai/andrew/openrouter/anthropic/claude-sonnet-4) --- src/meta_plugin/digest.rs | 24 ++++++++++++ src/meta_plugin/system.rs | 80 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 104 insertions(+) diff --git a/src/meta_plugin/digest.rs b/src/meta_plugin/digest.rs index 75e949c..2575f93 100644 --- a/src/meta_plugin/digest.rs +++ b/src/meta_plugin/digest.rs @@ -19,6 +19,14 @@ impl DigestSha256MetaPlugin { _options: Option>, outputs: Option>, ) -> DigestSha256MetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -114,6 +122,14 @@ impl ReadTimeMetaPlugin { _options: Option>, outputs: Option>, ) -> ReadTimeMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -197,6 +213,14 @@ impl ReadRateMetaPlugin { _options: Option>, outputs: Option>, ) -> ReadRateMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); diff --git a/src/meta_plugin/system.rs b/src/meta_plugin/system.rs index 0e56740..211fe41 100644 --- a/src/meta_plugin/system.rs +++ b/src/meta_plugin/system.rs @@ -22,6 +22,14 @@ impl CwdMetaPlugin { _options: Option>, outputs: Option>, ) -> CwdMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -114,6 +122,14 @@ impl UidMetaPlugin { _options: Option>, outputs: Option>, ) -> UidMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -202,6 +218,14 @@ impl UserMetaPlugin { _options: Option>, outputs: Option>, ) -> UserMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -293,6 +317,14 @@ impl GidMetaPlugin { _options: Option>, outputs: Option>, ) -> GidMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -381,6 +413,14 @@ impl GroupMetaPlugin { _options: Option>, outputs: Option>, ) -> GroupMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -472,6 +512,14 @@ impl ShellMetaPlugin { _options: Option>, outputs: Option>, ) -> ShellMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -563,6 +611,14 @@ impl ShellPidMetaPlugin { _options: Option>, outputs: Option>, ) -> ShellPidMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -654,6 +710,14 @@ impl KeepPidMetaPlugin { _options: Option>, outputs: Option>, ) -> KeepPidMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -742,6 +806,14 @@ impl HostnameMetaPlugin { _options: Option>, outputs: Option>, ) -> HostnameMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs(); @@ -833,6 +905,14 @@ impl FullHostnameMetaPlugin { _options: Option>, outputs: Option>, ) -> FullHostnameMetaPlugin { + // Start with default options + let mut final_options = std::collections::HashMap::new(); + if let Some(opts) = _options { + for (key, value) in opts { + final_options.insert(key, value); + } + } + // Start with default outputs let mut final_outputs = std::collections::HashMap::new(); let default_outputs = Self::default().default_outputs();