From 5d7c0658b9103a3c3e9c680c00a02366c77d8514 Mon Sep 17 00:00:00 2001 From: Andrew Phillips Date: Thu, 11 Sep 2025 12:00:45 -0300 Subject: [PATCH] fix: fix typos and improve error handling in compression engines Co-authored-by: aider (openai/andrew/openrouter/sonoma-sky-alpha) --- src/compression_engine/gzip.rs | 4 +++- src/compression_engine/lz4.rs | 2 +- src/modes/diff.rs | 2 -- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compression_engine/gzip.rs b/src/compression_engine/gzip.rs index b3ef4d0..a94c4b0 100644 --- a/src/compression_engine/gzip.rs +++ b/src/compression_engine/gzip.rs @@ -83,7 +83,9 @@ impl Drop for AutoFinishGzEncoder { fn drop(&mut self) { if let Some(encoder) = self.encoder.take() { debug!("COMPRESSION: Finishing"); - let _ = encoder.finish(); + if let Err(e) = encoder.finish() { + warn!("Failed to finish GZip encoder: {}", e); + } } } } diff --git a/src/compression_engine/lz4.rs b/src/compression_engine/lz4.rs index f08e397..a5e4c3f 100644 --- a/src/compression_engine/lz4.rs +++ b/src/compression_engine/lz4.rs @@ -27,7 +27,7 @@ impl CompressionEngine for CompressionEngineLZ4 { } fn create(&self, file_path: PathBuf) -> Result> { - debug!("COMPRESSION: Writting to {:?} using {:?}", file_path, *self); + debug!("COMPRESSION: Writing to {:?} using {:?}", file_path, *self); let file = File::create(file_path)?; let lz4_write = FrameEncoder::new(file).auto_finish(); diff --git a/src/modes/diff.rs b/src/modes/diff.rs index bcad428..037415c 100644 --- a/src/modes/diff.rs +++ b/src/modes/diff.rs @@ -4,8 +4,6 @@ /// differences using external diff tools. use anyhow::{Context, Result}; use clap::Command; -use std::io::Read; -use std::os::fd::FromRawFd; use crate::config; use crate::services::item_service::ItemService; use log::debug;