From 0f06d314234c472d3d75f29ede7801e7209ebc0e Mon Sep 17 00:00:00 2001
From: Andrew Phillips <andrew.phillips2@canada.ca>
Date: Sun, 10 Aug 2025 00:27:02 -0300
Subject: [PATCH] fix: remove unused imports, unnecessary mutable variables,
 and dead code

Co-authored-by: aider (openai/andrew/openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
---
 src/modes/common.rs | 32 --------------------------------
 src/modes/save.rs   |  2 +-
 src/modes/update.rs |  4 ++--
 3 files changed, 3 insertions(+), 35 deletions(-)

diff --git a/src/modes/common.rs b/src/modes/common.rs
index fea2916..e732cde 100644
--- a/src/modes/common.rs
+++ b/src/modes/common.rs
@@ -108,38 +108,6 @@ pub fn get_digest_type_meta(digest_type: MetaPluginType) -> String {
     format!("digest_{}", digest_type.to_string().to_lowercase())
 }
 
-pub fn store_item_meta_value(
-    conn: &mut Connection,
-    item: Item,
-    meta_name: String,
-    meta_value: String,
-) -> Result<(), anyhow::Error> {
-    // Save digest to meta
-    let meta = Meta {
-        id: item.id.ok_or_else(|| anyhow!("Item missing ID"))?,
-        name: meta_name,
-        value: meta_value,
-    };
-    store_meta(conn, meta)?;
-    Ok(())
-}
-
-pub fn store_item_digest_value(
-    conn: &mut Connection,
-    item: Item,
-    digest_type: MetaPluginType,
-    digest_value: String,
-) -> Result<(), anyhow::Error> {
-    // Save digest to meta
-    let digest_meta_name = get_digest_type_meta(digest_type);
-    let digest_meta = Meta {
-        id: item.id.ok_or_else(|| anyhow!("Item missing ID"))?,
-        name: digest_meta_name,
-        value: digest_value,
-    };
-    store_meta(conn, digest_meta)?;
-    Ok(())
-}
 
 pub fn cmd_args_digest_type(cmd: &mut Command, args: &Args) -> MetaPluginType {
     let digest_name = args
diff --git a/src/modes/save.rs b/src/modes/save.rs
index 3fff68d..8d68c94 100644
--- a/src/modes/save.rs
+++ b/src/modes/save.rs
@@ -245,7 +245,7 @@ pub fn mode_save(
     setup_item_metadata(conn, args, &item, tags)?; // Pass mutable reference
 
     // Use a transaction for database operations to ensure atomicity
-    let mut tx = conn.transaction()?;
+    let tx = conn.transaction()?;
 
     let item_meta = collect_item_meta(args);
     let item_id = item.id.ok_or_else(|| anyhow!("Item missing ID"))?;
diff --git a/src/modes/update.rs b/src/modes/update.rs
index 0a70ed0..f61f65d 100644
--- a/src/modes/update.rs
+++ b/src/modes/update.rs
@@ -5,7 +5,7 @@ use std::str::FromStr;
 use crate::compression_engine::{CompressionType, get_compression_engine};
 use crate::db;
 use crate::meta_plugin;
-use crate::modes::common::{cmd_args_digest_type, get_digest_type_meta, store_item_digest_value};
+use crate::modes::common::{cmd_args_digest_type, get_digest_type_meta};
 use clap::Command;
 use clap::error::ErrorKind;
 use log::{debug, info};
@@ -36,7 +36,7 @@ pub fn mode_update(
     debug!("MAIN: Found item {:?}", item);
 
     // Use a transaction for database operations to ensure atomicity
-    let mut tx = conn.transaction()?;
+    let tx = conn.transaction()?;
 
     if !tags.is_empty() {
         debug!("MAIN: Updating item tags");